astitcher commented on a change in pull request #289:
URL: https://github.com/apache/qpid-proton/pull/289#discussion_r558373586
##########
File path: python/proton/_delivery.py
##########
@@ -34,7 +34,7 @@
class NamedInt(int):
- values = {} # type: Dict[int, str]
Review comment:
The doc for mypy says that Dict is available in typing for 2.7 - not
sure what's going on here, but I strongly think we should ignore or silence
flake8 here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
