jiridanek commented on a change in pull request #289:
URL: https://github.com/apache/qpid-proton/pull/289#discussion_r558373070
##########
File path: python/tox.ini
##########
@@ -25,6 +25,33 @@ deps =
changedir = {[tox]setupdir}
commands = flake8
+[flake8]
+# TODO(PROTON-2322) decrease the limit
+max-line-length = 150
+
+# TODO(PROTON-2322) re-enable all these warnings
+ignore =
+ # do not use bare 'except'
+ E722,
+ # imported but unused
+ F401,
+ # 'from proton import *' used; unable to detect undefined names
+ F403,
Review comment:
it's small compared to what dispatch has; and I think it is worth it,
just to preserve the style fixes already in.
I am thinking, is flake8 running against the test code, currently? Afaik
with this setting it doesn't, it only checks what's installed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
