jiridanek commented on a change in pull request #289:
URL: https://github.com/apache/qpid-proton/pull/289#discussion_r558381006
##########
File path: python/proton/_delivery.py
##########
@@ -34,7 +34,7 @@
class NamedInt(int):
- values = {} # type: Dict[int, str]
Review comment:
That's not enough, it has to be imported. And that would make `typing` a
runtime dependency of the client. I could have a conditional import, of course,
but that is IMO at the same level of messiness as the current state.
And Python 2.7 is out-of-support at this point anyways, and Proton will drop
it in one or two versions. I think that the comment is fine until we go for 3.6
minimum in Proton, which will be in few months, as I understand it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
