jiridanek commented on a change in pull request #289:
URL: https://github.com/apache/qpid-proton/pull/289#discussion_r558399078
##########
File path: python/proton/_delivery.py
##########
@@ -34,7 +34,7 @@
class NamedInt(int):
- values = {} # type: Dict[int, str]
Review comment:
Whether flake8 runs under pyhotn2 or python3 probably plays a role here.
In Python 3 code, you are supposed to have that `from typing import Dict`; if
you forget, it's an error that flake8 can help you with.
The flake8 error this produced is
```
30: ./proton/_delivery.py:37:18: F821 undefined name 'Dict'
```
so exactly same result as if you used that name in your code. I don't see a
way to tell flake8 not to behave like this, except with the # noqa comment.
There is only a single type annotation like this. I strongly believe that
what's in the PR is adequate until Proton moves to 3.6. Then we can simply do
`from typing import` and we'll do type annotations the 3.x way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
