astitcher commented on a change in pull request #289:
URL: https://github.com/apache/qpid-proton/pull/289#discussion_r558389831
##########
File path: python/proton/_delivery.py
##########
@@ -34,7 +34,7 @@
class NamedInt(int):
- values = {} # type: Dict[int, str]
Review comment:
Also re type comments - I'm much more interested in typeshed (as in
separate) function level type annotations - I think I put that comment there as
a helpful piece of user level info to help me understand the code.
I don't think having flake8 check this is very useful tbh, so just stop it
checking type annotation for the moment.
If I want type checking I'm going to use mypy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
