There’s some edge cases which seem problematic. One example: ComboBoxBiew has the following: input = new TextInput(); input.className = "ComboBoxTextInput"; button = new TextButton(); button.className = "opt_org-apache.royale-html-ComboBox_Button";
Input and button are both external to the view class, but are managed by the view class. On the other hand, there is a chance that the user might wan to style them. I’m not sure whether className or typeNames is more appropriate here… Harbs > On Feb 23, 2018, at 11:03 AM, Gabe Harbs <harbs.li...@gmail.com> wrote: > > I’ll help. > >> On Feb 23, 2018, at 10:50 AM, Alex Harui <aha...@adobe.com.INVALID> wrote: >> >> Quick note before I shut down for the night. >> >> UIBase has both a typeNames and className property. TypeNames is used to >> emulate Flex-like type selectors in the CSS lookup. It should be set in >> the constructor and never set from outside the class. There are a few >> classes in Basic and lots of classes in MDL that should be upgraded to set >> typeNames in the constructor. Subclasses can append to the base class's >> typeNames >> >> className is the opposite. It should never be set inside the component's >> class. It is for users of that component to set styles on the component. >> >> Can we get a volunteer to clean this up? >> >> Thanks, >> -Alex >> >