lewismc commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173495801
##########
File path:
core/src/main/java/org/apache/sdap/mudrod/recommendation/structure/MetadataTokenizer.java
##########
@@ -109,10 +106,12 @@ public MetadataOpt(Properties props) {
for (SearchHit hit : scrollResp.getHits().getHits()) {
Map<String, Object> result = hit.getSource();
- String shortName = (String) result.get("Dataset-ShortName");
+ String shortName = (String) result.get(metadataName);
String filedStr = "";
- for (String filed : variables) {
+ int size = variables.size();
Review comment:
Use enhanced for loop if possible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
