lewismc commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173491555
##########
File path:
core/src/main/java/org/apache/sdap/mudrod/integration/LinkageIntegration.java
##########
@@ -173,32 +171,32 @@ public JsonObject getIngeratedListInJson(String input) {
* the similarities from different sources
*/
public Map<String, List<LinkedTerm>>
aggregateRelatedTermsFromAllmodel(String input) {
- aggregateRelatedTerms(input, props.getProperty("userHistoryLinkageType"));
- aggregateRelatedTerms(input, props.getProperty("clickStreamLinkageType"));
- aggregateRelatedTerms(input, props.getProperty("metadataLinkageType"));
- aggregateRelatedTermsSWEET(input,
props.getProperty("ontologyLinkageType"));
+ aggregateRelatedTerms(input, MudrodConstants.USE_HISTORY_LINKAGE_TYPE);
Review comment:
This code should be
```
aggregateRelatedTerms(input,
props.getProperty(MudrodConstants.USE_HISTORY_LINKAGE_TYPE));
```
same with three instance below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
