lewismc commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173496602
##########
File path:
core/src/main/java/org/apache/sdap/mudrod/weblog/pre/ImportLogFile.java
##########
@@ -306,9 +306,9 @@ public void parseSingleLineHTTP(String log, String index,
String type) {
CrawlerDetection crawlerDe = new CrawlerDetection(this.props, this.es,
this.spark);
if (!crawlerDe.checkKnownCrawler(agent)) {
boolean tag = false;
- String[] mimeTypes = { ".js", ".css", ".jpg", ".png", ".ico",
"image_captcha", "autocomplete", ".gif", "/alldata/", "/api/", "get /
http/1.1", ".jpeg", "/ws/" };
- for (String mimeType : mimeTypes) {
- if (request.contains(mimeType)) {
+ String[] mimeTypes =
props.getProperty(MudrodConstants.BLACK_LIST_REQUEST).split(",");
+ for (int i = 0; i < mimeTypes.length; i++) {
Review comment:
If possible use enhanced for loop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
