[
https://issues.apache.org/activemq/browse/SM-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Mueller updated SM-1623:
----------------------------------
Attachment: SmppSenderEndpoint.java.patch
pom.xml.patch
Hello Jean-Baptiste,
I'm happy with the progress of this smpp binding component and I have played
with it (get from your svn repo). Thank you for your work.
I will give you some feedback for further improvements:
- With your last commit (revision 17) you add the dependency to 'sl4j'
instead of 'slf4j' (missing 'f') :o)
- see pom.xml.patch
- For an easy test, I want to read the sms message with a file poller and
send it to the smpp sender. Because the file poller supports only In-Only
MEPs, and I think it's a good idee that the smpp component also supports the
In-Onyl (and Robust-In-Only) MEP, I have added the 'processInOnly' method.
- In the 'processInOut' method, the checks of ExchangeStatus.DONE,
ExchangeStatus.ERROR and exchange.getFault() are not necessary, because the
super class ProviderEndpoint ensures this (this is my understanding).
- see SmppSenderEndpoint.java.patch
- For a more advanced test, I have intermediary a eip pipeline to bridge
from the file pollers In-Only MEP to the smpp senders In-Out MEP and send
the response to a file sender. In this scenario, I got an Exception. I don'
why, but I will looking for that at the evening...
I hope my feedback is welcome and helpfully...
Regards,
Christian
> New binding component: SMPP
> ---------------------------
>
> Key: SM-1623
> URL: https://issues.apache.org/activemq/browse/SM-1623
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-components
> Reporter: Rohit Joshi
> Assignee: Jean-Baptiste Onofré
> Attachments: pom.xml.patch, SmppSenderEndpoint.java.patch
>
>
> I am submitting here source code for SMPP binding component. See the
> attached tar file.
> Attached servicemix-component.tar file contains following files. It should be
> deployed under apache-servicemix-3.2.2/src/common directory.
> ********
> SOURCE
> ***********
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPMarshaler.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPPoller.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPSender.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/servicemix.xml
> ******
> TEST
> ********
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPPollTest.java
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPTest.java
> *********
> pom.xml
> ********
> servicemix-components/pom.xml
> this file adds the dependency on smppapi.
> <dependency>
> <groupId>smppapi</groupId>
> <artifactId>smppapi</artifactId>
> <version>0.3.7</version>
> <optional>false</optional>
> </dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
