[ 
https://issues.apache.org/activemq/browse/SM-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Mueller updated SM-1623:
----------------------------------

    Attachment: SmppSenderEndpoint.java.patch

Hi Jean-Baptiste,

I'm not sure, whether a MEP property is necessary in the
'SmppSenderEndpoint'. 'SmppSenderEndpoint' can support In-Only,
Robust-In-Only and In-Out, depending on the request MEP.
'SmppPoolerEndpoint' should have a MEP property and support the In-Only and
Robust-In-Only MEPs.

I fixed the problem I had with the In-Out MEP:
- The call 'this.getChannel().send(exchange);' in the 'processInOut' method
of the 'SmppSenderEndpoint' is not necessary, bacause the super class
'ProviderEndpoint' call this method for us, after calling 'processInOut'.
- Because we reading the source of the normalized in message multiple times,
we need to call 'MessageUtil.enableContentRereadability(in);' before we read
the source the first time. Else, we receive a
'javax.xml.transform.TransformerException: java.io.IOException: Stream
closed'.
- The call to 'MessageUtil.transferInToOut(exchange, exchange);' throws an
'MessagingException', because the normalized out message is not null (see
line 360 of 'org.apache.servicemix.jbi.messaging.MessageExchangeImpl'). I
(and also my manually tests) thinking that 'MessageUtil.transfer(in, out);'
does the right.
- see SmppSenderEndpoint.java.patch (patch to revision 17)

Regards,
Christian


> New binding component: SMPP
> ---------------------------
>
>                 Key: SM-1623
>                 URL: https://issues.apache.org/activemq/browse/SM-1623
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-components
>            Reporter: Rohit Joshi
>            Assignee: Jean-Baptiste Onofré
>         Attachments: pom.xml.patch, SmppSenderEndpoint.java.patch, 
> SmppSenderEndpoint.java.patch
>
>
> I am submitting here source code for SMPP binding component.   See the 
> attached tar file.  
> Attached servicemix-component.tar file contains following files. It should be 
> deployed under  apache-servicemix-3.2.2/src/common directory.
> ********
> SOURCE
> ***********
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPMarshaler.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPPoller.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPSender.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/servicemix.xml
> ******
> TEST
> ********
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPPollTest.java
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPTest.java
> *********
> pom.xml
> ********
> servicemix-components/pom.xml
>  this file adds the dependency on smppapi.
> <dependency>
>             <groupId>smppapi</groupId>
>             <artifactId>smppapi</artifactId>
>             <version>0.3.7</version>
>             <optional>false</optional>
>  </dependency>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to