[
https://issues.apache.org/activemq/browse/SM-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48965#action_48965
]
Lars Heinemann commented on SM-1623:
------------------------------------
* I think 'SmppConsumerEndpoint' is the better name, bacause this component
is subclassed from 'ConsumerEndpoint' and not from 'PollingEndpoint' and
follows the smx naming schema (e.G. 'JmsConsumerEndpoint',
'HttpConsumerEndpoint', ...).
--> There are other components using Poller and Sender...so no need to change
it imho.
* now, you configure the consumer endpoint with '<smpp:consumer ...>'
instead of '<smpp:poller ...>'
--> see above
* The check in the validate method, whether the 'getMarshaller()' call
returns an instance of 'SmppMarshaller' is not necessary, because
'getMarshaller()' returns an 'SmppMarshaller'.
--> well. You are right here but if someone tries to put a class in here which
is not
implementing the SmppMarshalerSupport interface it will just throw a
ClassCastException.
We can safely remove this check. (Nanthrax, could you do that?)
* Modify the 'process()' method (now, acts like the 'QuartzEndpoint')
--> well...the naming is not really the best because it makes you think it
overrides the process method from
the super class.
* Added the defaultMep property and getter/setter with the default to
'In-Only' (analog to HttpConsumerEndpoint)
--> that sounds interesting. But as a first step the InOnly would be enough.
Just imagine what happens when
using a InOut exchange. What do you do with the result from the NMR? Then
you need to implement sending
logic inside the poller endpoint. I would leave that away for the moment.
* Modify the 'connect()' method to create the MessageExchange for the
configured MEP (In-Only or Robust-In-Only), configure the exchange and
send
it.
--> see above
Thanks for the input Christian. Please refer to the official version in the ASF
repo in future because it makes it easier to
apply patches.
Regards
Lars
> New binding component: SMPP
> ---------------------------
>
> Key: SM-1623
> URL: https://issues.apache.org/activemq/browse/SM-1623
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-components
> Reporter: Rohit Joshi
> Assignee: Jean-Baptiste Onofré
> Attachments: pom.xml.patch, smpp_consumer_endpoint.patch,
> SmppSenderEndpoint.java.patch, SmppSenderEndpoint.java.patch
>
>
> I am submitting here source code for SMPP binding component. See the
> attached tar file.
> Attached servicemix-component.tar file contains following files. It should be
> deployed under apache-servicemix-3.2.2/src/common directory.
> ********
> SOURCE
> ***********
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPMarshaler.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPPoller.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPSender.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/servicemix.xml
> ******
> TEST
> ********
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPPollTest.java
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPTest.java
> *********
> pom.xml
> ********
> servicemix-components/pom.xml
> this file adds the dependency on smppapi.
> <dependency>
> <groupId>smppapi</groupId>
> <artifactId>smppapi</artifactId>
> <version>0.3.7</version>
> <optional>false</optional>
> </dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
