[ 
https://issues.apache.org/activemq/browse/SM-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Mueller updated SM-1623:
----------------------------------

    Attachment: smpp_consumer_endpoint.patch

Hi Jean-Baptiste,

thanks, I got the svn repo updates (revision 20).
Today, I worked on the 'SmppPollerEndpoint':
- I think 'SmppConsumerEndpoint' is the better name, bacause this component
is subclassed from 'ConsumerEndpoint' and not from 'PollingEndpoint' and
follows the smx naming schema (e.G. 'JmsConsumerEndpoint',
'HttpConsumerEndpoint', ...).
- now, you configure the consumer endpoint with '<smpp:consumer ...>'
instead of '<smpp:poller ...>'
- The check in the validate method, whether the 'getMarshaller()' call
returns an instance of 'SmppMarshaller' is not necessary, because
'getMarshaller()' returns an 'SmppMarshaller'.
- Modify the 'process()' method (now, acts like the 'QuartzEndpoint')
- Added the defaultMep property and getter/setter with the default to
'In-Only' (analog to HttpConsumerEndpoint)
- Modify the 'connect()' method to create the MessageExchange for the
configured MEP (In-Only or Robust-In-Only), configure the exchange and send
it.
- see smpp_consumer_endpoint.patch

I hope you agree with my changes...

Regards,
Christian


> New binding component: SMPP
> ---------------------------
>
>                 Key: SM-1623
>                 URL: https://issues.apache.org/activemq/browse/SM-1623
>             Project: ServiceMix
>          Issue Type: Improvement
>          Components: servicemix-components
>            Reporter: Rohit Joshi
>            Assignee: Jean-Baptiste Onofré
>         Attachments: pom.xml.patch, smpp_consumer_endpoint.patch, 
> SmppSenderEndpoint.java.patch, SmppSenderEndpoint.java.patch
>
>
> I am submitting here source code for SMPP binding component.   See the 
> attached tar file.  
> Attached servicemix-component.tar file contains following files. It should be 
> deployed under  apache-servicemix-3.2.2/src/common directory.
> ********
> SOURCE
> ***********
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPMarshaler.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPPoller.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPSender.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/servicemix.xml
> ******
> TEST
> ********
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPPollTest.java
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPTest.java
> *********
> pom.xml
> ********
> servicemix-components/pom.xml
>  this file adds the dependency on smppapi.
> <dependency>
>             <groupId>smppapi</groupId>
>             <artifactId>smppapi</artifactId>
>             <version>0.3.7</version>
>             <optional>false</optional>
>  </dependency>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to