[
https://issues.apache.org/activemq/browse/SM-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48962#action_48962
]
Jean-Baptiste Onofré commented on SM-1623:
------------------------------------------
Hi Christian,
In response to your comment :
* I'm agree to rename SmppPollerEndpoint to SmppConsumerEndpoint. I make the
change now.
* I change the xbean element too
* As you can define your own marshaler (you have a marshaler property), I check
if the marshaler provided by the user is a SmppMarshaler (instanceof). That's
why you have this check in the validate() method. If the user hasn't define its
own marshaler, I set a default one, else I check if the one provided is a
SmppMarshaler.
* I check and merge your changes as I have already added the defaultMep
property :)
Thanks
Regards
JB
> New binding component: SMPP
> ---------------------------
>
> Key: SM-1623
> URL: https://issues.apache.org/activemq/browse/SM-1623
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-components
> Reporter: Rohit Joshi
> Assignee: Jean-Baptiste Onofré
> Attachments: pom.xml.patch, smpp_consumer_endpoint.patch,
> SmppSenderEndpoint.java.patch, SmppSenderEndpoint.java.patch
>
>
> I am submitting here source code for SMPP binding component. See the
> attached tar file.
> Attached servicemix-component.tar file contains following files. It should be
> deployed under apache-servicemix-3.2.2/src/common directory.
> ********
> SOURCE
> ***********
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPMarshaler.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPPoller.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPSender.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/servicemix.xml
> ******
> TEST
> ********
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPPollTest.java
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPTest.java
> *********
> pom.xml
> ********
> servicemix-components/pom.xml
> this file adds the dependency on smppapi.
> <dependency>
> <groupId>smppapi</groupId>
> <artifactId>smppapi</artifactId>
> <version>0.3.7</version>
> <optional>false</optional>
> </dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
