Good suggestion. I will send a new thread to discuss feature acceptance test.
------------------ Liang Zhang (John) Apache ShardingSphere & Dubbo 吴晟 Sheng Wu <[email protected]> 于2019年3月25日周一 上午9:54写道： > > We have CI environment to do integrate test. In checklist, we hope > PPMC/committer team do acceptance test for this release tar. > > If feature tests are part of this release vote, I think this may be a > little too complex. > Meaning, this vote could become test discussion. > For example, let's say some feature tests fail, which could happen in any > release, should I call a (-1) or do we need to discuss how to process it? > This could be really uncertain. We could do a release with bugs, even some > feature broken, such as alpha, beta releases. > Even for stable release, we can't guarantee that. > > > I ask for this, because I hope the community to decide this commit id is > the right one, then vote on whether the release is following ASF way. > In incubator, these are two things. > > > Because my +1 and IPMC +1(s) for a release vote are most likely not > related to feature, but could trigger misleading others. > > > > We have release notes here: > > https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md > > Look good to me > > > ------------------ > Sheng Wu > Apache SkyWalking, ShardingSphere, Zipkin > Twitter, wusheng1108 > > > > > > > > ------------------ Original ------------------ > From: "[email protected]"<[email protected]>; > Date: Mon, Mar 25, 2019 09:43 AM > To: "dev"<[email protected]>; > > Subject: Re: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0 > [RC1] > > > > > 1. We haven't asked the PPMC/committer team to do the feature tests for > this release. At least nothing happens in ML(which means haven't done in > ASF). I think before vote, we should do that. > > We have CI environment to do integrate test. In checklist, we hope > PPMC/committer team do acceptance test for this release tar. > > > 2. Release note should be a part of document repo or release src tar > ball, rather than GitHub draft page[1]. The reason is, release notes should > be kept permanently. > > We have release notes here: > > https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md > > ------------------ > > Liang Zhang (John) > Apache ShardingSphere & Dubbo > > > 吴晟 Sheng Wu <[email protected]> 于2019年3月25日周一 上午9:37写道： > > > Hi > > > > > > I have noticed two things. > > 1. We haven't asked the PPMC/committer team to do the feature tests for > > this release. At least nothing happens in ML(which means haven't done in > > ASF). I think before vote, we should do that. > > 2. Release note should be a part of document repo or release src tar > ball, > > rather than GitHub draft page[1]. The reason is, release notes should be > > kept permanently. > > > > > > Could we do adjustments for these two? Before we call for a vote. > > > > > > [1] > > > https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-90bdf1e5cbba8422332f > > > > > > ------------------ > > Sheng Wu > > Apache SkyWalking, ShardingSphere, Zipkin > > Twitter, wusheng1108 > > > > > > > > > > > > > > > > ------------------ Original ------------------ > > From: "[email protected]"<[email protected]>; > > Date: Mon, Mar 25, 2019 09:02 AM > > To: "dev"<[email protected]>; > > > > Subject: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0 [RC1] > > > > > > > > Hello ShardingSphere Community, > > > > This is a call for vote to release Apache ShardingSphere (Incubating) > > version 4.0.0-RC1 > > > > Release notes: > > > > > https://github.com/apache/incubator-shardingsphere/releases/edit/untagged-90bdf1e5cbba8422332f > > > > The release candidates: > > > https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC1/ > > > > Maven 2 staging repository: > > > > > https://repository.apache.org/content/repositories/staging/org/apache/shardingsphere/ > > > > Git tag for the release: > > https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC1 > > > > Release Commit ID: > > > > > https://github.com/apache/incubator-shardingsphere/commit/90a17fd3ac5af99d0fe1bd8018ba1393b1864672 > > > > Keys to verify the Release Candidate: > > https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS > > > > The vote will be open for at least 72 hours or until necessary number of > > votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > ------------------ > > > > Liang Zhang (John) > > Apache ShardingSphere & Dubbo
