Hi Craig, > When there is a change to the bits being discussed, I would encourage you to change the name. In this case, I would change to RC2 which indicates that there is a change from the bits discussed as RC1
> I would suggest including the checklist link in the [DISCUSS] thread. (If only to give the mentors a chance to review as well.) Good suggestion, we can check checklist at thread [1] and [2], or create a new thread to check them. > When this comes to the [VOTE], it will be very useful to include these links showing the results of the discussion. OK, after discussion, we can create a new thread to show result, title maybe [RESULT] [DISCUSSION] xxx So, we just leave this vote thread and replay other thread's result here, or cancel this vote and create new vote for round 2 when discuss and check finished? ------------------ Liang Zhang (John) Apache ShardingSphere & Dubbo Craig Russell <apache....@gmail.com> 于2019年3月29日周五 下午1:10写道： > Hi John, > > > On Mar 28, 2019, at 8:43 PM, zhangli...@apache.org wrote: > > > >> I think that the original vote from March 25 didn't expire but was > > canceled and now we have a new vote, right? > > > > Yes, it is cancelled. I will reply that thread to make it clear. > > > >> If there is no change to the bits uploaded to > > dist/incubator/shardingsphere, we don't need to call a new vote just > > because 3 days pass. > > > > It is changed, add some missing licenses files. > > When there is a change to the bits being discussed, I would encourage you > to change the name. In this case, I would change to RC2 which indicates > that there is a change from the bits discussed as RC1 > > > >> This might be a good time to consider having a [DISCUSS] Release Apache > > ShardingSphere (Incubating) 4.0.0 [RC1] thread before calling a [VOTE] > > Release Apache ShardingSphere (Incubating) 4.0.0 [RC1] thread > > > > The first time to vote, we don't send email to discuss. For second time > to > > vote, we have discuss in thread[1], the conclusion is in thread [2]. > > Good practice. > > > >> Do we have release checklist? It should include how to verify checksums, > > signatures, > > > > Yes, I have checked checklist during release. And we should let other > PPMC > > to check them before they vote. The document is [3]. > > I would suggest including the checklist link in the [DISCUSS] thread. (If > only to give the mentors a chance to review as well.) > > > >> which tests to run (not the CI automated ones but can users run mvn > > install or some other command which include tests?) > > > > We checked at thread [1] and [2]. > > When this comes to the [VOTE], it will be very useful to include these > links showing the results of the discussion. > > Regards, > > Craig > > > > [1] > > > https://lists.apache.org/thread.html/953e8d42e7106d4d5dd29f61ece6c10c8210a9c48232c7fb90484851@%3Cdev.shardingsphere.apache.org%3E > > [2] > > > https://lists.apache.org/thread.html/2099ff699a427565f978b9f020ffa289c001acea62642408b95b0203@%3Cdev.shardingsphere.apache.org%3E > > [3] https://shardingsphere.apache.org/community/en/contribute/release/ > > ------------------ > > > > Liang Zhang (John) > > Apache ShardingSphere & Dubbo > > > > > > Craig Russell <apache....@gmail.com> 于2019年3月29日周五 上午7:58写道： > > > >> Hi, > >> > >> I realize I'm coming late to this discussion... > >> > >>> On Mar 28, 2019, at 11:36 AM, 吴晟 Sheng Wu <wu.sh...@foxmail.com> > wrote: > >>> > >>> Could you add the (take 1/round 1) in your mail title? In order to make > >> the vote clear in ml. > >> > >> I'd agree that we need to be more clear when conducting votes. I think > >> that the original vote from March 25 didn't expire but was canceled and > now > >> we have a new vote, right? If there is no change to the bits uploaded to > >> dist/incubator/shardingsphere, we don't need to call a new vote just > >> because 3 days pass. > >> > >> This might be a good time to consider having a > >> > >> [DISCUSS] Release Apache ShardingSphere (Incubating) 4.0.0 [RC1] thread > >> before calling a > >> > >> [VOTE] Release Apache ShardingSphere (Incubating) 4.0.0 [RC1] thread > >> > >> Do we have release checklist? It should include how to verify checksums, > >> signatures, which tests to run (not the CI automated ones but can users > run > >> mvn install or some other command which include tests?) > >> > >> Craig > >>> > >>> > >>> It looks like confused to me. > >>> > >>> > >>> ------------------ > >>> Sheng Wu > >>> Apache SkyWalking, ShardingSphere, Zipkin > >>> Twitter, wusheng1108 > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> ------------------ Original ------------------ > >>> From: "zhangli...@apache.org"<zhangli...@apache.org>; > >>> Date: Thu, Mar 28, 2019 08:55 PM > >>> To: "dev"<dev@shardingsphere.apache.org>; > >>> > >>> Subject: Re: [VOTE]: Release Apache ShardingSphere (Incubating) 4.0.0 > >> [RC1] > >>> > >>> > >>> > >>> Thread [1] is expired. > >>> > >>> [1] > >>> > >> > https://lists.apache.org/thread.html/a0f7b8187f94c94e1d47ab468e030df1f04a8827e428ed72710f3bec@%3Cdev.shardingsphere.apache.org%3E > >>> > >>> ------------------ > >>> > >>> Liang Zhang (John) > >>> Apache ShardingSphere & Dubbo > >>> > >>> > >>> zhangli...@apache.org <zhangli...@apache.org> 于2019年3月28日周四 下午8:40写道： > >>> > >>>> Hello ShardingSphere Community, > >>>> > >>>> This is a call for vote to release Apache ShardingSphere (Incubating) > >>>> version 4.0.0-RC1 > >>>> > >>>> Release notes: > >>>> > >>>> > >> > https://github.com/apache/incubator-shardingsphere/releases/tag/untagged-a7276f4b3f5fb99f2c2b > >>>> > >>>> The release candidates: > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC1/ > >>>> > >>>> Maven 2 staging repository: > >>>> > >>>> > >> > https://repository.apache.org/content/repositories/staging/org/apache/shardingsphere/ > >>>> > >>>> Git tag for the release: > >>>> https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC1 > >>>> > >>>> Release Commit ID: > >>>> > >>>> > >> > https://github.com/apache/incubator-shardingsphere/commit/709b5f58793be11e19309b59554ad5f7df19f9e0 > >>>> > >>>> Keys to verify the Release Candidate: > >>>> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS > >>>> > >>>> The vote will be open for at least 72 hours or until necessary number > of > >>>> votes are reached. > >>>> > >>>> Please vote accordingly: > >>>> > >>>> [ ] +1 approve > >>>> [ ] +0 no opinion > >>>> [ ] -1 disapprove with the reason > >>>> > >>>> ------------------ > >>>> > >>>> Liang Zhang (John) > >>>> Apache ShardingSphere & Dubbo > >> > >> Craig L Russell > >> c...@apache.org > >> > >> > > Craig L Russell > c...@apache.org > >
