https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7982
--- Comment #11 from Sidney Markowitz <sid...@sidney.com> --- I identified 12 tests that require a total of 20 rules/*.cf files. That does not count tests that I didn't run, including network and root tests and any others that got skipped in my configuration. I encountered a huge problem when I tried adding just those required files to the rules directory: t/basic_meta.t started failing because some of those rules have dependencies on others that were not in the rules directory. I think the only possible solutions are to either go through all those tests and change them to test without requiring rules from the rules directory, or else go ahead and include all the rules in the installation tar. I don't think it will be practical to have to update MANIFEST every time a rule file is added, removed or renamed. I don't like the prospect of manually putting all rule files in MANIFEST as part of the release process. Since the release build script already gathers all the rule files to make the rules tar that is distributed for running a local sa-update, the script could put the files in the install tar at the same time. Is there a problem if we distribute the install tar with files that are not listed in MANIFEST? Is there anything that checks for extra files? Any thoughts or other suggestions on this? In case anyone will want to work on removing the dependency of tests on rules, here is the list of what I found. This does not include the large number of dependencies on 20_aux_tlds.cf basic_meta2.t requires 10_default_prefs.cf header_utf8.t requires 60_welcomelist.cf mimeheader.t requires 10_default_prefs.cf priorities.t requires 23_bayes.cf 60_welcomelist.cf priorities_welcome_block.t requires 23_bayes.cf 60_welcomelist.cf shortcircuit.t requires 60_shortcircuit.cf welcomelist_addrs.t requires 60_awl.cf whitelist_addrs.t requires 60_awl.cf welcomelist_subject.t requires 60_welcomelist_subject.cf whitelist_subject.t requires 60_welcomelist_subject.cf t/sql_based_welcomelist.t requires 10_default_prefs.cf 10_hasbase.cf 20_body_tests.cf 20_compensate.cf 20_drugs.cf 20_freemail.cf 20_freemail_domains.cf 20_head_tests.cf 20_html_tests.cf 20_meta_tests.cf 20_ratware.cf 20_uri_tests.cf 20_vbounce.cf 50_scores.cf 60_awl.cf t/sql_based_whitelist.t requires 10_default_prefs.cf 10_hasbase.cf 20_body_tests.cf 20_compensate.cf 20_drugs.cf 20_freemail.cf 20_freemail_domains.cf 20_head_tests.cf 20_html_tests.cf 20_meta_tests.cf 20_ratware.cf 20_uri_tests.cf 20_vbounce.cf 50_scores.cf 60_awl.cf -- You are receiving this mail because: You are the assignee for the bug.
