https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7982

--- Comment #15 from Henrik Krohns <apa...@hege.li> ---
(In reply to Sidney Markowitz from comment #14)
> Ok, the real problem seems to be frustratingly simple.
> 
> t/SATest.pm uses t/data/01_test_rules.cf for its rules so it does not have
> to depend on the ever changing contents of rules. When running in a trunk
> checkout directory, all the current rules in the rules directory are
> available, so nobody noticed that the file has gotten out of date with
> changes to the tests.
> 
> As far as I can tell the correct way to fix this is to identify the rules
> dependencies of the tests and update 01_test_rules.cf to suit. I'll start
> working on that.

Does the fix make sense though? As mentioned, isn't it a advatage that "make
test" actually tests that current trunk/rules does what it's supposed to
correctly?

If you have stuff in 01_test_rules.cf, it's overridden anyway from trunk/rules
as all the stuff is copied to t/.../localrules.

This means now you would have to always remember to check if 01_test_rules.cf
is up to date and nothing in trunk/rules is overriding it. This seems to make
01_test_rules.cf obsolete if you ask me.

It would be trivial to just copy trunk/rules to distribution tarball, I don't
understand why it would even confuse users, they probably wouldn't even notice
it..

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to