https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7982
--- Comment #18 from Henrik Krohns <apa...@hege.li> ---
(In reply to Sidney Markowitz from comment #17)
> Along those lines, I would really like it if someone could look at
> sql_based_welcomelist.t and figure out how to make it dependent on much
> fewer rules. As far as I can tell it has test cases that are designed to
> trigger different rules and it checks that the expected results get
> processed. What it is testing has nothing to do with those specific rules,
> they are just used to see if the expected strings are generated. But each
> such rule adds a requirement for one or more rule files to be available.
I can fix it easily, but it depends on how you want to fix it.
For example it's assumed that data/nice/002 hits these rules to get a -2 score,
which the string match expects
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
-1.0 NICE_REPLY_A Looks like a legit reply (A)
Even if I fix sql_based_welcomelist.t, can we be sure that no other tests rely
on a nice mail getting negative score? It could get convoluted.
Then we must decide if we want to make sql_based_whitelist.t completely
independent of 01_test_rules.cf. Why should it rely on that if we can just put
all the needed rules into sql_based_whitelist.t directly, that would be the
most well documented and maintained option? This can simply be achieved by
cleaning out $localrules from sql_based_whitelist.t.
--
You are receiving this mail because:
You are the assignee for the bug.
