https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7982
--- Comment #21 from Sidney Markowitz <sid...@sidney.com> --- (In reply to Sidney Markowitz from comment #19) > I don't think it is worthwhile to rewrite sql_based_welcomelist.t. As you > say, other rules could do the same thing with data/nice/002. Now that I have slept on it, I think it is totally a correct thing to do to rewrite sql_based_welcomelist.t, but not to give it internal rules. The biggest change in the test compared to what it did in 3.4.6 is that it checks for an exact score result. The subtests look for scores 0, -2, -4, -6, -8, 9.837 and 0 When I run with a minimal rule set and just the changes to 01_test_rules.cf that I added to get the other tests to pass, the scores that the subtests get are 0, 0, 0, 0, 0, 10, and 0 I don't know if those new 0's mean that the test is not getting testing what it is supposed to. Henrik, can you come up with a rewrite of the test that still tests what it needs to in the sql based welcomelist, but does not break if the scores come out somewhat different? That should solve the biggest problem here. -- You are receiving this mail because: You are the assignee for the bug.
