https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7982

--- Comment #13 from Sidney Markowitz <sid...@sidney.com> ---
(In reply to Kevin A. McGrail from comment #12)
> Primarily, I would likely look at what changed between 3.4.6 and 4.0

I can do that. I do think it would be much simpler all around if the tests did
not require the rules that happen to be in trunk on the day the tests were
written. That's just too brittle, tests should be more self-contained and
written to check specific functionality. sql_based_welcomelist.t and
sql_based_whitelist.t are particularly bad, judging from how many rules they
seem to require.

That's a good point to see if I can understand what exactly is different in
3.4.6 that makes this not a problem there.

I do have a small patch to the build script that adds the rules to MANIFEST in
the working directory before the tar is built and immediately reverts it so we
would not have to keep MANIFEST in svn updated with rule changes. But as you
imply, better to understand and fix the problem instead of taking a
sledgehammer to it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to