Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57166147
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -508,7 +509,7 @@
^Integer max-spout-pending (if max-spout-pending (int
max-spout-pending))
last-active (atom false)
spouts (ArrayList. (map :object (vals task-datas)))
- rand (Random. (Utils/secureRandomLong))
+ rand (XORShiftRandom. (Utils/secureRandomLong))
--- End diff --
We cannot use a thread local random here, because it is placed into
functions that are not called from a single thread. What is more the
implementation of XORShiftRandom is that if we do lose the race, it is likely
that we will repeat a number which could result in tuples not being tracked
properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
