Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167305
--- Diff: storm-core/src/jvm/org/apache/storm/grouping/ShuffleGrouping.java
---
@@ -35,7 +36,7 @@
@Override
public void prepare(WorkerTopologyContext context, GlobalStreamId
stream, List<Integer> targetTasks) {
- random = new Random();
+ random = new XORShiftRandom();
--- End diff --
Same as above. Having repeated numbers is not a big deal here, but we do
want to have a comment declaring that this is safe and what the ramifications
are.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
