Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57166843
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -698,7 +699,7 @@
executor-stats (:stats executor-data)
{:keys [storm-conf component-id worker-context transfer-fn
report-error sampler
open-or-prepare-was-called?]} executor-data
- rand (Random. (Utils/secureRandomLong))
+ rand (XORShiftRandom. (Utils/secureRandomLong))
--- End diff --
Same reason as with the spout, but differently. There is a much higher
likelihood that this will be used in a non-thread safe way. But it is less
likely that it will result in a tuple being counted improperly, unless multiple
threads are emitting tuples for the same tuple tree. It is unlikely, but still
not necessarily safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
