Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167003
--- Diff:
storm-core/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -36,7 +37,7 @@
@Override
public void prepare(WorkerTopologyContext context, GlobalStreamId
stream, List<Integer> targetTasks) {
- random = new Random();
+ random = new XORShiftRandom();
--- End diff --
Thread safety here is nice, but not a requirement. If we double up on a
few routs it is probably not that big of a deal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
