Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167152
--- Diff:
storm-core/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -36,7 +37,7 @@
@Override
public void prepare(WorkerTopologyContext context, GlobalStreamId
stream, List<Integer> targetTasks) {
- random = new Random();
+ random = new XORShiftRandom();
--- End diff --
Mostly if we are going to use something that is not thread safe here we
should explain why it is OK, and what the drawbacks are, because this is
supposed to be thread safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
