Github user carl34 commented on the issue:

    https://github.com/apache/storm/pull/2126
  
    @priyank5485, setting client.id is useful for identifying requests Kafka 
protocol packets.  For instance, we have many topologies which run on a shared 
Storm cluster using storm-kafka and all of the fetch requests contain blank 
"Client ID:" values.  We would like to have a clear way for our developers to 
set client.id so that we can quickly determine the source of Kafka packets.  
    
    For storm-kafka-client, I get your point that setProp can be used, but we 
would like to encourage our users to set this parameter so we would appreciate 
if it was clearly available with the builder pattern via intellisense.
    
    Here is an example fetch request from storm-kafka without a client.id:
    ```
    Kafka (Fetch Request)
        Length: 54
        API Key: Fetch (1)
        API Version: 0
        Correlation ID: 0
        String Length: 0
        Client ID:
        Replica ID: -1
        Max Wait Time: 10000
        Min Bytes: 0
        Array Count: 1
        Fetch Request Topic (1 partitions)
            String Length: 6
            Topic Name: canary
            Array Count: 1
            Fetch Request Partition (Partition-ID=2, Offset=162438425)
                Partition ID: 2
                Offset: 162438425
                Max Bytes: 1048576
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to