Github user priyank5485 commented on the issue:
https://github.com/apache/storm/pull/2126
@carl34 Good point. I did not realize it was final until you brought it up.
In that case i am okay with your change for storm-kafka module. For
storm-kafka-client module i still prefer avoiding the method setCliendId. I
would rather use setProp instead. Can you use setProp instead on the builder
for now? And when i create a PR for refactoring storm-kafka-client you can
comment about any issues that you might run in to because of the changes in the
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---