GitHub user carl34 reopened a pull request:

    https://github.com/apache/storm/pull/2126

    Add the option to set client.id to storm-kafka and storm-kafka-client

    Add the ability to set the Kafka client.id property to storm-kafka and 
storm-kafka-client (https://issues.apache.org/jira/browse/STORM-2524).
    
    storm-kafka example:
    ```
        SpoutConfig spoutConfig = new SpoutConfig(
                brokers,
                topicConfs.topic,
    +           "client_id-" + confs.consumerGroupId + "-" + topicConfs.topic,
                "/consumers",
                confs.consumerGroupId + "-" + topicConfs.topic
        );
    ```
    
    storm-kafka-client example:
    ```
        KafkaSpoutConfig<String,String> kafkaSpoutConfig = 
KafkaSpoutConfig.builder(KAFKA_LOCAL_BROKER, TOPIC)
                .setGroupId(confs.consumerGroupId + "-" + topicConfs.topic)
    +           .setClientId("client_id-" + confs.consumerGroupId + "-" + 
topicConfs.topic)
                .build();
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/carl34/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2126
    
----
commit ca50f699a4f7b50ef2f463ed076297abeabd321a
Author: Carl Haferd <chaf...@groupon.com>
Date:   2017-05-17T20:04:53Z

    Add the option to set client.id to storm-kafka

commit cb543c0393d23ae93c0394697d5a555037cee486
Author: carl34 <car...@users.noreply.github.com>
Date:   2017-05-22T20:26:25Z

    Merge pull request #3 from carl34/kafka_client_id
    
    Add the option to set client.id to storm-kafka

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to