Github user priyank5485 commented on the issue:
https://github.com/apache/storm/pull/2126
@carl34
https://github.com/apache/storm/blob/master/external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaConfig.java#L32
is already a public property. Are you saying passing it as a constructor
argument is more clear than setting a public property? If yes, I dont agree
with you on that. That extra constructor does not add any value. Plus,
community is encouraged to use new spout. So unless there is a blocker or
critical bug in the old spout i prefer not changing any code there.
For storm-kafka-client I plan to raise a PR to get rid of the builder
pattern. Builder pattern relies on builder.build() and pass the returned object
to the constructor. Unfortunately, that does not work well with flux. Hence
setProp method, either on the builder (or may be in future directly on
KafkaSpoutConfig) is encouraged. There are so many other properties on kafka
consumer api. It does not make sense to expose each one of those as a setXXX
java method. Without those setXXX methods it is a much cleaner api for spout
and its config object. Intellisense should not be the top priority here. I
would prefer a cleaner api.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
