Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2126#discussion_r117774461
--- Diff: external/storm-kafka/pom.xml ---
@@ -57,7 +57,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
- <maxAllowedViolations>557</maxAllowedViolations>
+ <maxAllowedViolations>558</maxAllowedViolations>
--- End diff --
I would prefer to see the violations fixed instead of adding in new ones.
In this case I suspect that it is missing javadocs for the new SpoutConfig
constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
