Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152368599
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public LogviewerLogSearchHandler(Map<String, Object>
stormConf, String logRoot,
this.logRoot = logRoot;
this.daemonLogRoot = daemonLogRoot;
this.resourceAuthorizer = resourceAuthorizer;
-
- this.logviewerPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_PORT));
+ Integer httpsPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_HTTPS_PORT), 0);
--- End diff --
@srdo I think the issue is around converting the number to an Integer. If
`ObjectReader.getInt` does not have a default option it will throw an exception
on a null value which is the default. But I think we could make it cleaner by
doing something like
```
Object httpsPort = stormConf.get(DaemonConfig.LOGVIEWER_HTTPS_PORT);
if (httpsPort == null) {
this.logviewerPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_PORT));
this.scheme = "http";
} else {
this.logviewerPort = ObjectReader.getInt(httpsPort);
this.scheme = "https";
}
```
---
