Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152407885
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public LogviewerLogSearchHandler(Map<String, Object>
stormConf, String logRoot,
this.logRoot = logRoot;
this.daemonLogRoot = daemonLogRoot;
this.resourceAuthorizer = resourceAuthorizer;
-
- this.logviewerPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_PORT));
+ Integer httpsPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_HTTPS_PORT), 0);
--- End diff --
Actually in the old clojure code we did validate it every time we loaded it.
https://github.com/apache/storm/blob/67c65e774f20d3091caed6da82d155887e966772/storm-core/src/clj/org/apache/storm/config.clj#L72-L80
Not sure what happened with the translation but it is a regression if we
are not doing it any more.
---
