Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152434183
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public LogviewerLogSearchHandler(Map<String, Object>
stormConf, String logRoot,
this.logRoot = logRoot;
this.daemonLogRoot = daemonLogRoot;
this.resourceAuthorizer = resourceAuthorizer;
-
- this.logviewerPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_PORT));
+ Integer httpsPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_HTTPS_PORT), 0);
--- End diff --
@Ethanlm
You're right about using which method to use: Only first one validates the
fields. We should fix it, maybe better to rename `Utils.readStormConfig()` or
even move the logic to ConfigUtils if we don't find any place which should use
Utils.readStormConfig() instead of ConfigUtils'.
Btw, `ConfigValidation.validateFields` also validates DaemonConfig, if we
have storm-server in classpath. Please refer
https://issues.apache.org/jira/browse/STORM-832 and its patch
https://github.com/apache/storm/pull/2065.
---
