Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152392265
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public LogviewerLogSearchHandler(Map<String, Object>
stormConf, String logRoot,
this.logRoot = logRoot;
this.daemonLogRoot = daemonLogRoot;
this.resourceAuthorizer = resourceAuthorizer;
-
- this.logviewerPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_PORT));
+ Integer httpsPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_HTTPS_PORT), 0);
--- End diff --
@srdo @revans2 Thanks for the comments. It seems to me that
`ConfigValidation.validateFields` is only used to validate topology
configurations. It's not used to validate the confs daemons use before
launching the daemons.
---
