Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r153216647
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public LogviewerLogSearchHandler(Map<String, Object>
stormConf, String logRoot,
this.logRoot = logRoot;
this.daemonLogRoot = daemonLogRoot;
this.resourceAuthorizer = resourceAuthorizer;
-
- this.logviewerPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_PORT));
+ Integer httpsPort =
ObjectReader.getInt(stormConf.get(DaemonConfig.LOGVIEWER_HTTPS_PORT), 0);
--- End diff --
It still seems not right to me. If we change `Utils.readStormConfig()` to
`ConfigUtil.readStormConfig()` in `LogviewerServer`, we require the
`LOGVIEWER_HTTPS_PORT` to be `@isInteger` and `@isPositiveNumber`. Then we will
have to use https for logviewer in any cases and never be able to use http.
See:
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java#L239
---
