Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165829893
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -210,23 +215,26 @@ public Builder(String bootstrapServers, Subscription
subscription) {
}
/**
- * Set a {@link KafkaConsumer} property.
+ * Set a {@link KafkaConsumer} property. Please don't set
enable.auto.commit, instead set the {@link ProcessingGuarantee}
--- End diff --
Should we leave this info here, or add it to the [s-k-c
documentation](https://github.com/apache/storm/blob/master/docs/storm-kafka-client.md)?
I would say it belongs in s-k-c documentation. However, if we find it is too
important, we can leave it here. Regardless of the location, I would write
something along the lines:
"the Kafka property enable.auto.commit is not supported and if set will
throw an exception. All other Kafka properties that control Kafka auto commit
mechanism, if set will be ignored.
---
