Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830316
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java
---
@@ -196,13 +206,37 @@ public void
testAtMostOnceModeDoesNotCommitAckedTuples() throws Exception {
}
@Test
- public void testAnyTimesModeDoesNotCommitAckedTuples() throws
Exception {
- //When tuple tracking is enabled, the spout must not commit acked
tuples in any-times mode because committing is managed by the consumer
+ public void testNoneModeCommitsPolledTuples() throws Exception {
+ //When using the none guarantee, the spout must commit tuples
periodically, regardless of whether they've been acked
--- End diff --
no-guarantee
---
