Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2537#discussion_r165830142
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -519,6 +519,15 @@ private boolean isEmitTuple(List<Object> tuple) {
             return tuple != null || kafkaSpoutConfig.isEmitNullTuples();
         }
     
    +    private void commitConsumedOffsets(Set<TopicPartition> 
assignedPartitions) {
    --- End diff --
    
    perhaps the name of this method should be "commitFetchedOffsetsAsync" based 
on the javadoc for 
[kafkaConsumer.position(tp)](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L1396)


---

Reply via email to