srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024422
##########
File path:
external/storm-hdfs-blobstore/src/test/java/org/apache/storm/hdfs/blobstore/BlobStoreTest.java
##########
@@ -535,6 +523,6 @@ public void testMultiple(BlobStore store)
fail("Error the blobstore is of unknowntype");
}
assertStoreHasExactly(store, "test");
- readAssertEquals(store, "test", 3);
+ readAssertEquals(store, "test", 4);
Review comment:
This is a bugfix in the test. The test wasn't previously running, so this
line hasn't been passing. Note that the code above writes 4 here
https://github.com/apache/storm/pull/2990/files#diff-a48145dd5bbd83aced6dd85b1d85ec64L527.
It is then reasonable to assert that the stored value is 4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
