srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024711
##########
File path:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java
##########
@@ -203,15 +209,13 @@ public void testEmptySimpleText_ACK() throws Exception {
conf.put(Config.TOPOLOGY_ACKER_EXECUTORS, "1"); // enable ACKing
openSpout(spout, 0, conf);
- // consume empty file
- runSpout(spout, "r1");
- Path arc1 = new Path(archive.toString() + "/file_empty.txt");
Review comment:
I believe this test was added after I accidentally turned off tests. It has
never worked. The comments below should describe what the test is doing, and
how we want the spout to behave.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
