srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024769
##########
File path:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java
##########
@@ -772,7 +773,7 @@ public MockTextFailingReader(FileSystem fs, Path file,
Map<String, Object> conf)
private final int componentId;
public MockTopologyContext(int componentId, Map<String, Object>
topoConf) {
- super(null, topoConf, null, null, null, null, null, null, null,
null, null, null, null, null, null, null, null, null);
+ super(null, topoConf, null, null, null, null, null, null, null, 0,
0, null, null, null, null, null, null, null);
Review comment:
TopologyContext throws an exception if you give it null task id now. I think
it is weird to give it null for Integer-type variables, so I've just set both
to null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
