srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024575
##########
File path:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java
##########
@@ -192,6 +195,9 @@ public void testEmptySimpleText_ACK() throws Exception {
Path file1 = new Path(source.toString() + "/file_empty.txt");
createTextFile(file1, 0);
+ //Ensure the second file has a later modified timestamp, as the spout
should pick the first file first.
Review comment:
This is me being a little paranoid about test flakiness. As far as I can
tell, the spout reads files ordered by modified timestamp, and if the above two
lines run in the same millisecond as the below two, we might read the files in
the wrong order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
