srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when
shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024485
##########
File path:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSemantics.java
##########
@@ -124,7 +125,7 @@ public void testAppendSemantics() throws Exception {
//2 try to append to a closed file
try (FSDataOutputStream os2 = fs.append(file1)) {
- assertThat(os2, notNull());
+ assertThat(os2, notNullValue());
Review comment:
The tests weren't running, so this has always been wrong. Switching to the
right matcher fixes the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
