Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/38#issuecomment-46475004
For the most part things look good. I one very minor comment about an
error string, and one comment about the testing. Using simulated time should
make the test run a lot faster and be less prone to timing differences on
different systems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---