williaster commented on a change in pull request #3993: [Explore view] Use POST
method for charting requests
URL:
https://github.com/apache/incubator-superset/pull/3993#discussion_r156466889
##########
File path:
superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
##########
@@ -101,13 +106,43 @@ class ExploreViewContainer extends React.Component {
}
}
+ addHistory(isReplace = false, title) {
+ const { payload } = createExplore(this.props.form_data);
+ const longUrl = getExploreLongUrl(this.props.form_data);
+ if (isReplace) {
+ history.replaceState(
+ payload,
+ document.title,
+ longUrl);
+ } else {
+ history.pushState(
+ payload,
+ document.title,
+ longUrl);
+ }
+
+ // it seems browsers don't support pushState title attribute
Review comment:
some do right? otherwise it wouldn't be an input to `push/replaceState`?
maybe caveat with "some browsers"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
