williaster commented on a change in pull request #3993: [Explore view] Use POST
method for charting requests
URL:
https://github.com/apache/incubator-superset/pull/3993#discussion_r161937581
##########
File path: superset/assets/spec/javascripts/explore/utils_spec.jsx
##########
@@ -12,48 +13,124 @@ describe('utils', () => {
expect(uri1.toString()).to.equal(uri2.toString());
}
- it('getExploreUrl generates proper base url', () => {
+ it('generates proper base url', () => {
Review comment:
do you think the tests should include the util func name? you do this
inconsistently here and less readable if not. you could also create a dedicated
`describe` block for a given func if you want to omit the name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
