williaster commented on a change in pull request #3993: [Explore view] Use POST
method for charting requests
URL:
https://github.com/apache/incubator-superset/pull/3993#discussion_r161933961
##########
File path:
superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
##########
@@ -43,13 +43,13 @@ class ExploreChartHeader extends React.PureComponent {
slice_name: newTitle,
action: isNewSlice ? 'saveas' : 'overwrite',
};
- const saveUrl = getExploreUrl(this.props.form_data, 'base', false, null,
params);
- this.props.actions.saveSlice(saveUrl)
+ this.props.actions.saveSlice(this.props.form_data, params)
.then((data) => {
if (isNewSlice) {
this.props.actions.createNewSlice(
data.can_add, data.can_download, data.can_overwrite,
data.slice, data.form_data);
+ this.props.addHistory({ isReplace: true, title: '[slice] ' +
data.slice.slice_name });
Review comment:
nit - template literals? there's inconsistent usage in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
