williaster commented on a change in pull request #3993: [Explore view] Use POST
method for charting requests
URL:
https://github.com/apache/incubator-superset/pull/3993#discussion_r161933627
##########
File path: superset/assets/javascripts/explore/components/EmbedCodeButton.jsx
##########
@@ -29,7 +30,7 @@ export default class EmbedCodeButton extends React.Component
{
generateEmbedHTML() {
const srcLink = (
window.location.origin +
Review comment:
it's strange to use string templates and concatenation. can we just use the
template?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
