williaster commented on a change in pull request #3993: [Explore view] Use POST
method for charting requests
URL:
https://github.com/apache/incubator-superset/pull/3993#discussion_r156472304
##########
File path: superset/assets/spec/javascripts/explore/utils_spec.jsx
##########
@@ -12,48 +13,84 @@ describe('utils', () => {
expect(uri1.toString()).to.equal(uri2.toString());
}
- it('getExploreUrl generates proper base url', () => {
+ it('createExplore generates proper base url', () => {
Review comment:
prob outside the scope of this PR but just a thought for test organization,
if you break out a `describe('specific utils func...', () => { ... })` you
wouldn't have to repeat the name for each test and could say `expect('it
....')`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
